Help Obi rope deleteingt cutted part after cut?

[josemendez]

Code:

ObiSolver.ParticleInActor pa = solver.particleToActor[particleIndex];

        //solver.colors[particleIndex] = Color.black;

        obiRopes[0].Tear(obiRopes[0].elements[pa.indexInActor + 1]);

        for (int i = pa.indexInActor + 1; i < obiRopes[0].elements.Count; i++)
        {
            obiRopes[0].DeactivateParticle(solver.particleToActor[obiRopes[0].elements[i].particle2].indexInActor);
            obiRopes[0].elements.RemoveAt(i);
        }

        obiRopes[0].RebuildConstraintsFromElements();

        foreach (ObiRopeCursor cr in cursors)
        {
            cr.cursorMu = (float)pa.indexInActor / (float)obiRopes[0].activeParticleCount;
            cr.UpdateCursor();
        }

Here is my code . I am not sure about the for loop

Hi there!

I don't think I'll be able to post full functioning code today, I will on monday for sure. However at first glance the for loop looks suspicious indeed.
RemoveAt(i) moves all elements in the list at indices larger than "i" one index back, and reduces the list length by one (see: https://docs.microsoft.com/en-us/dotnet/...ew=net-5.0)

This will cause the for loop to skip over elements. When removing elements while iterating trough an array/list, do it backwards:

Code:

for (int i = obiRopes[0].elements.Count -1; i >= pa.indexInActor + 1, --i)

This will prevent any issues, since all elements shifted when removing one have been already visited by the for loop. It's also more efficient, since the amount of shifting that needs to be done is minimized.

There might be other issues with your code, hold on and I'll post a fully working version asap.