Thanks ! It really helps a lot !
Hi !
I've read the paper and found the equation of the intersection in section 4.1 very confusing.
As $\widetilde{q}$ is defined to be $\widetilde{q} = \frac{1}{\widetilde{r}}\left\{\begin{matrix}\widetilde{x} \\ \widetilde{y}\end{matrix}\right\}$ ,
so I think the square of $\widetilde{q}$ should be $\widetilde{q}^2=\frac{1}{\widetilde{r}^2}(\widetilde{x}^2+\widetilde{y}^2)$,
not $\widetilde{q}^2=\frac{1}{\widetilde{r}}(\widetilde{x}^2+\widetilde{y}^2)$.
Then maybe the code in function IntersectEllipsoid in file ObiEllipsoids.cginc for calclulating iq
float iq = 1 - r2/mapping.w;
should be
float iq = 1 - r2/(mapping.w * mapping.w);
I'm not sure if I'm right, please let me know if I've misunderstood about this part.
Hi !
I've read the paper and found the equation of the intersection in section 4.1 very confusing.
As $\widetilde{q}$ is defined to be $\widetilde{q} = \frac{1}{\widetilde{r}}\left\{\begin{matrix}\widetilde{x} \\ \widetilde{y}\end{matrix}\right\}$ ,
so I think the square of $\widetilde{q}$ should be $\widetilde{q}^2=\frac{1}{\widetilde{r}^2}(\widetilde{x}^2+\widetilde{y}^2)$,
not $\widetilde{q}^2=\frac{1}{\widetilde{r}}(\widetilde{x}^2+\widetilde{y}^2)$.
Then maybe the code in function IntersectEllipsoid in file ObiEllipsoids.cginc for calclulating iq
float iq = 1 - r2/mapping.w;
should be
float iq = 1 - r2/(mapping.w * mapping.w);
I'm not sure if I'm right, please let me know if I've misunderstood about this part.