(26-02-2019, 02:22 PM)josemendez Wrote: Hi,

In your code you're removing all actors from the solver, even those that have been already removed. Clearing the _GeneratedActors list at the end of RemoveAllGenerated() fixes the issue. Re-(re-re-re- )removing actors is not good practice, however it should not crash.

There's indeed a bug in Obi that causes redundant removal of cloth actors to unpin memory multiple times. Place lines 214-220 of ObiCloth.cs inside the "if" clause right before them. The entire method should then look like this:

Code:

bool removed = false;

        try{

            // re-enable Unity skinning:
            if (clothMesh != null)
                clothMesh.boneWeights = sharedMesh.boneWeights;

            if (solver != null && InSolver){
                Oni.DestroyDeformableMesh(Solver.OniSolver,deformableMesh);
                deformableMesh = IntPtr.Zero;

                Oni.UnpinMemory(particleIndicesHandle);
                Oni.UnpinMemory(meshTrianglesHandle);
                Oni.UnpinMemory(meshVerticesHandle);
                Oni.UnpinMemory(meshNormalsHandle);
                Oni.UnpinMemory(meshTangentsHandle);
    
                CallOnDeformableMeshTearDown();
            }

        }catch(Exception e){
            Debug.LogException(e);
        }finally{
            removed = base.RemoveFromSolver(info);
        }
        return removed;

Let me know how it goes, and thanks for reporting this!

(26-02-2019, 04:45 PM)mmortall Wrote: josemendez,
Am I understand you right that if Oni.UnpinMemory called twice this leads to crash?

Is there a way to debug it. For example to get Error when it is called twice or something like this?
Because I get another crash, less often. And would be great to have some way to get assert or error in case if memory get corrupted

Update:
I added this code to UnpinMemory function. Will try to locale the problem

Code:

public static void UnpinMemory(GCHandle handle)
{
  if (handle.IsAllocated && _AllUnlinnedHandles.Contains(handle))
  {
     Debug.LogError("Trying to UnpinMemory for already unpinned handler");
     return;
  }
 
  if (handle.IsAllocated)
  {
     _AllUnlinnedHandles.Add(handle);
     
     handle.Free();
  }
}

(26-02-2019, 08:50 PM)josemendez Wrote: Nope, calling unpin twice won't do anything. Unpin only does something if the memory is pinned. Will try to reproduce these issues.